Skip to content

feat: release v1.2.0 - #31

Merged
AlinsRan merged 2 commits into
mainfrom
release/v1.1.2
Nov 18, 2026
Merged

AlinsRan merged 2 commits into
mainfrom
release/v1.1.2

Conversation

@jarvis9443

@jarvis9443 jarvis9443 commented Nov 18, 2026 •

Copy link
Copy Markdown

Release 1.2.0: error_metric_labels option for metric_data() and collect() (#30). A minor release, as it adds an API.

@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Explain Change →

Warning

Review limit reached

  • Run on-demand review

This review includes 3 billable files and costs up to $0.75.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 14 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available. Your 54 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 59a39b24-2261-46bc-a6df-d9fa4dec5928
Commits

Reviewing files that changed from the base of the PR and between ae4b58b and 808c6e8.

Files selected for processing: 3

  • CHANGELOG.md
  • dist.ini
  • rockspec/nginx-lua-prometheus-api7-1.2.0-1.rockspec

No actionable comments were generated in the recent review.

Walkthrough

The changelog adds a 1.1.2 entry describing optional error_metric_labels maps. The package version, rockspec version, and rockspec source tag are updated to 1.1.2.

Changes: Version 1.1.2 release

Layer / File(s) Summary
Release notes and version metadata
CHANGELOG.md, dist.ini, rockspec/nginx-lua-prometheus-api7-1.1.2-1.rockspec
The changelog documents optional error_metric_labels maps for metric_data() and collect(). Package and rockspec metadata change to version 1.1.2, including the rockspec source tag.

Estimated code review effort: 1 (Trivial) | ~4 minutes

Possibly related PRs

Suggested reviewers: alinsran, shreemaan-abhishek

Merge Risk: Minimal · previous review ae4b5

This release change updates the changelog and the package version metadata to 1.1.2. It does not change runtime behavior, so merging it carries little risk.

Pre-merge checks: Passed 5 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Title check Warning The title "feat: release v1.2.0" does not match the changeset. The raw summary and PR objectives describe a 1.1.2 release that adds the optional error_metric_labels maps for metric_data() and collect(… Rename the PR to match the changeset, for example "feat: add error_metric_labels and release v1.1.2" or "release: v1.1.2". Confirm the intended version number first, because the dist.ini and rockspec changes both set 1.1.2.
Passed Passed checks: 5 passed

Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
E2e Test Quality Review Passed Summary: The check is not applicable to this pull request. It changes no code and adds no tests, so there is no test or code logic to review against the E2E criteria. Evidence: - `git diff --s…
Security Check Passed Summary: The PR changes only release metadata and documentation. The security checklist does not apply to these changes, and I found no failure condition in the changed code. **Changed files (from…
Full details: E2e Test Quality Review

Explanation

Summary: The check is not applicable to this pull request. It changes no code and adds no tests, so there is no test or code logic to review against the E2E criteria. Evidence: - git diff --stat main HEAD shows three changed files: CHANGELOG.md (+7), dist.ini (version bump), and the rockspec renamed from 1.1.1-1 to 1.2.0-1. Total: 3 files, 10 insertions, 3 deletions. - No .lua, .t, or other test or source files change. The repository has no t/ or test/ directory. - The error_metric_labels feature came in with PR #30 (acda607), which is already on main. This PR only packages that change as a release. - The summary and description describe the release only. Neither adds an API, logic, or test. Note (outside this check): The CHANGELOG summary describes a 1.1.2 entry, but the diff sets the version to 1.2.0 and the PR title and description say v1.2.0. The version labels do not match. This does not affect the E2E test criteria. Because no tests or code changed, no E2E completeness, scenario coverage, assertion, mock, error-handling, concurrency, or scope failure condition applies to this PR.

Full details: Security Check

Explanation

Summary: The PR changes only release metadata and documentation. The security checklist does not apply to these changes, and I found no failure condition in the changed code. Changed files (from the PR change summary): - CHANGELOG.md (+7/-0): adds a 1.1.2 changelog entry for the optional error_metric_labels maps. - dist.ini (+1/-1): version 1.1.1 to 1.1.2. - rockspec/nginx-lua-prometheus-api7-1.1.2-1.rockspec (+2/-2): version and source tag updated to 1.1.2. None of these files contain logging, serialization, credential handling, database models, authorization handlers, TLS settings, or secret resolution. Category 1 through 7 patterns do not match any changed line. Verification limits: - The local checkout does not contain the PR base. git diff origin/main...HEAD returned "no merge base". The local HEAD (808c6e8, "chore: release as v1.2.0") is a root commit that contains the full 1.2.0 tree. It is not the PR head (release/v1.1.2). - The PR patch therefore rests on the supplied change summary, not on a direct diff in this checkout. The summary lists every changed file and its line counts. - The local tree shows dist.ini at 1.2.0 and a 1.2.0 rockspec. This differs from the PR head, so I did not use it as evidence of the PR's changes. Identity: Provider-reported primary PR is api7/nginx-lua-prometheus#31, author login jarvis9443. The check does not use author identity. Conclusion: No changed code introduces a sensitive data exposure, unencrypted secret storage, authorization bypass, cross-resource access gap, TLS misconfiguration, shared-resource conflict, or unresolved secret reference. Each category is "No issues found" for this PR.

Full details: Title check

Explanation

The title "feat: release v1.2.0" does not match the changeset. The raw summary and PR objectives describe a 1.1.2 release that adds the optional error_metric_labels maps for metric_data() and collect(). The title names version 1.2.0, which appears nowhere in the changes. The title also omits the error_metric_labels feature, which is the main change.

Resolution

Rename the PR to match the changeset, for example "feat: add error_metric_labels and release v1.1.2" or "release: v1.1.2". Confirm the intended version number first, because the dist.ini and rockspec changes both set 1.1.2.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 165d3da6-e025-42f8-ad92-8cfbe3da8c8b
Commits

Reviewing files that changed from the base of the PR and between acda607 and ae4b58b.

Files selected for processing: 3

  • CHANGELOG.md
  • dist.ini
  • rockspec/nginx-lua-prometheus-api7-1.1.2-1.rockspec

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

@jarvis9443 jarvis9443 changed the title feat: release v1.1.2 feat: release v1.2.0 Nov 18, 2026
@AlinsRan
AlinsRan merged commit f00b087 into main Nov 18, 2026
5 checks passed
@AlinsRan
AlinsRan deleted the release/v1.1.2 branch November 18, 2026 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants