Repository navigation
fix(aisix): write the standalone resources examples in format v2 - #430
Draft
jarvis9443 wants to merge 1 commit into
Draft
jarvis9443 wants to merge 1 commit into
jarvis9443 wants to merge 1 commit into
Conversation
api7/aisix#1449 moved the resources file to `_format_version: "2"`: every entry carries an `id`, references name ids, and an API key is stored as `key_hash`. A gateway with that change refuses a v1 file at boot, so the standalone CI values and the README example would stop loading once `appVersion` reaches a release that includes it. The CI values now carry the caller key as a literal `key_hash` (the sha256 of the old placeholder), so neither the install test nor aisix-config-boot.sh needs `CALLER_API_KEY` any more.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has to merge together with the chart bump that moves
appVersionto a release containing api7/aisix#1449, and stays open until then. Please don't merge it on its own.api7/aisix#1449 switched the resources file to
_format_version: "2": every entry carries anid, references are written as ids, and an API key is stored askey_hash. A gateway with that change refuses a v1 file at boot, so onceappVersionincludes it the standalone install test would fail oncharts/aisix/ci/standalone-values.yaml, and the README example would no longer work.This rewrites both in v2. The README example (
README.md.gotmpl, withREADME.mdregenerated by helm-docs) now gives every entry anid, usesprovider_key_idandallowed_model_ids, and takes the caller key askey_hash: ${CALLER_API_KEY_SHA256}, with a short note on what the ids are and how to compute the hash. The CI values carry the caller key as a literalkey_hash, the sha256 of the old placeholder. That means the install test and.github/scripts/aisix-config-boot.shno longer needCALLER_API_KEY, so the script stops passing it.Until the bump,
aisix-config-boot.shboots the currentappVersionimage (1.10.0). That image only reads v1, so it is expected to fail on this branch.🤖 Generated with Claude Code