Repository navigation
check the first two characters for invalid xml chars in cdata save - #136
Merged
Merged
Conversation
pjfanning
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saving text that trips the CDATA heuristic (more than 32 chars and more than 5
</&) with a C0 control in the first or second position:The CDATA branch of
TextSaver.entitizeContentsplices the first character into<![CDATA[, reads the second one only to seed the]]>tracking, and starts itsisBadCharloop at the third. So the first two characters are written raw, while the same character at position three or later becomes?, as it does in the non-CDATA branch. The fix replaces a bad first character in the prefix and starts the loop at the second character. The buffer wrap check now also runs before that read, not after it. Valid text saves exactly as before.Added
CDataTest.badCharInCDatafor positions 0, 1 and 2. Positions 0 and 1 fail without the fix../gradlew testpasses.