Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while comparing the two xsd:QName lexical paths.
JavaQNameHolder.parse splits the value at the first colon, but the prefix NCName check is guarded by
prefix.length() > 0, so a colon with an empty prefix slips through::abcis outside the xsd:QName lexical space, yet it parses asabcbound to the default namespace. parse is the path the streaming Validator uses for xsd:QName and xsd:NOTATION values (via JavaQNameHolderEx / JavaNotationHolderEx.validateLexical) and the set path for XmlQName, so the bad value flows in from untrusted XML and validates clean. The rich parser path, XsTypeConverter.lexQName, already rejects a leading colon.The fix applies the existing prefix check whenever a colon is present; isValidNCName rejects the empty prefix like any other invalid one. Values without a colon and valid prefixed values are unchanged. Regression test added.
This fix was found and prepared with AI assistance and reviewed by me before submitting.