fix(realtime): keep spill outside the write mutex - #384
Merged
lxy-9602 merged 2 commits intoSep 23, 2026
Merged
Conversation
HaHaJeff
force-pushed
the
codex/realtime-spill-outside-write-mutex
branch
from
September 23, 2026 09:15
2e29525 to
c082cb8
Compare
lxy-9602
reviewed
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Follow up on #327 to avoid blocking realtime writes on sealed-segment spill I/O in append-only and primary-key writers.
Seal()andPrepareCommit()withprepare_mutex_.ArrowRealtimeStore::SealForCommit()outsiderealtime_store_mutex_. The store already protects segment rotation internally and spills outside its own mutex, allowing writes to the next building segment during spill.has_building_data_from the current offset and sealed range, preserving data written during spill.Tests
Local validation completed for this fix:
git diff --check: passed.pre-commitwas unavailable, so its checks were not run.API and Format
No public API, storage format, or protocol changes.
Documentation
No documentation changes; this fixes the existing spill behavior.
Generative AI tooling
Generated-by: OpenAI Codex (GPT-6)