Skip to content

docs(extensions): drop vendor-specific data examples from vendors.md & point to converters repo - #666

Merged
christianeu-db merged 2 commits into
apache:mainfrom
christianeu-db:remove-vendor-examples
Nov 1, 2026
Merged

christianeu-db merged 2 commits into
apache:mainfrom
christianeu-db:remove-vendor-examples

Conversation

@christianeu-db

@christianeu-db christianeu-db commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Summary

extensions/vendors.md carried a per-vendor Examples section that showed
sample custom_extensions[].data payloads (Snowflake, Salesforce, DBT,
Databricks). Ossie treats data as an opaque string that it carries but
does not interpret, so those examples implied a payload structure the core
spec does not actually define.

Additionally, some of these payloads are from before the converters were even
written, so may not even be valid.

This PR removes the Examples section and adds a line pointing readers to
the apache/ossie-converters
repository, where the precise extensions a given vendor emits and consumes
are defined. The Known vendors registry is unchanged.

Related Issues

Follows #617 - which removed vendors from core spec

Checklist

Documentation

  • docs/ is updated to reflect any user-facing changes

AI disclosure

Per the ASF Generative Tooling Guidance, this contribution was prepared with AI assistance. I have reviewed and verified every change.

The per-vendor `data` payload examples in vendors.md implied a structure
that Ossie does not define. Ossie carries `custom_extensions[].data` as an
opaque string, so the authoritative per-vendor extension details belong
with the converters, not the core registry.

Remove the Examples section and point readers to the
apache/ossie-converters repository for the precise extensions a given
vendor emits and consumes.

Co-authored-by: Isaac <no-reply@databricks.com>
@christianeu-db christianeu-db changed the title docs(extensions): drop vendor data examples from vendors.md docs(extensions): drop vendor-specific data examples from vendors.md & point to converters repo Oct 30, 2026
@christianeu-db
christianeu-db requested review from MonkeyCanCode, jbonofre and kayemkim and removed request for MonkeyCanCode and jbonofre October 30, 2026 21:42

@kayemkim kayemkim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One sentence still points at what this removes: core-spec/spec.md line 598 says "For vendor-specific extension examples and the known-vendor catalog, see extensions/vendors.md", and after this lands the file has the catalog but no examples. Dropping "vendor-specific extension examples and" there would close it. Nothing else reads those payloads, the vendor pin test parses the table line by line and passes on current main with this merged, and the converters README does carry the data convention the new pointer refers to.

The spec pointed readers to extensions/vendors.md for
"vendor-specific extension examples and the known-vendor catalog".
The companion change removes the examples from that file, so the
reference now points only at the known-vendor catalog.

Co-authored-by: Isaac <no-reply@databricks.com>
@github-actions github-actions Bot added the spec label Nov 1, 2026
@christianeu-db

Copy link
Copy Markdown
Contributor Author

@kayemkim Good catch. Dropped "vendor-specific extension examples and" from core-spec/spec.md, so the sentence now reads "For the known-vendor catalog, see extensions/vendors.md" - which matches the file's contents after this change

@kayemkim kayemkim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

11cfc14 reads as the file does after the change, and nothing else in the tree points at the removed examples.

@christianeu-db
christianeu-db merged commit 4732fd3 into apache:main Nov 1, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants