Skip to content

Simplify setReportPlugins conversion - #189

Draft
slachiewicz wants to merge 1 commit into
apache:masterfrom
slachiewicz:agent/sweep-prod-report-plugins
Draft

slachiewicz wants to merge 1 commit into
apache:masterfrom
slachiewicz:agent/sweep-prod-report-plugins

Conversation

@slachiewicz

@slachiewicz slachiewicz commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Simplify the model-to-exec ReportPlugin conversion in MavenReportExecutorRequest. Building a list removes the pre-sized array and manual index, and the redundant type witness in ReportPlugin.getReports() can be inferred.

  • Collect converted plugins in a List<ReportPlugin> and hand toArray(new ReportPlugin[0]) to the existing setter
  • Replace Collections.<String>emptyList() with Collections.emptyList()

Tracking: apache/maven#14072

Verified: JAVA_HOME=<Java 21> mvn -B -o verify → BUILD SUCCESS; per-class surefire counts unchanged (MavenReportExecutorRequestTest 1, TestDefaultMavenReportExecutor 4; 0 failures/errors)

@slachiewicz
slachiewicz marked this pull request as draft November 19, 2026 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant