Repository navigation
Simplify setReportPlugins conversion - #189
Draft
slachiewicz wants to merge 1 commit into
Draft
slachiewicz wants to merge 1 commit into
slachiewicz wants to merge 1 commit into
Conversation
slachiewicz
marked this pull request as draft
November 19, 2026 00:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify the model-to-exec
ReportPluginconversion inMavenReportExecutorRequest. Building a list removes the pre-sized array and manual index, and the redundant type witness inReportPlugin.getReports()can be inferred.List<ReportPlugin>and handtoArray(new ReportPlugin[0])to the existing setterCollections.<String>emptyList()withCollections.emptyList()Tracking: apache/maven#14072
Verified:
JAVA_HOME=<Java 21> mvn -B -o verify→ BUILD SUCCESS; per-class surefire counts unchanged (MavenReportExecutorRequestTest1,TestDefaultMavenReportExecutor4; 0 failures/errors)