Repository navigation
Explain why the legacy org.codehaus.doxia.sink.Sink stays - #188
Draft
slachiewicz wants to merge 1 commit into
Draft
slachiewicz wants to merge 1 commit into
slachiewicz wants to merge 1 commit into
Conversation
Removing it breaks mvn site for report plugins that still declare generate(org.codehaus.doxia.sink.Sink, Locale): jacoco-maven-plugin 0.8.16 fails with 'A required class was missing ... org/codehaus/doxia/sink/Sink'. Do not delete it in a deprecation cleanup; the test keeps the type in place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
org.codehaus.doxia.sink.Sink, deprecated since Doxia 1.0-alpha-6, looks like dead code, but it is load-bearing: report plugins that still declare the Maven 2 eragenerate(org.codehaus.doxia.sink.Sink, Locale)need it to load duringmvn site. With it removed, a site build with the JaCoCo report fails:This adds the reason to the class Javadoc and a test that references the type, so a deprecation cleanup cannot delete it unnoticed.
Verified: jacoco-maven-plugin 0.8.16
reportunder maven-site-plugin 3.22.0 → fails with this reporting-exec built without the class, passes with 2.0.1;mvn verify→ 6 tests and 5 ITs pass.