Skip to content

Remove unused test fixture fields - #106

Draft
slachiewicz wants to merge 1 commit into
apache:masterfrom
slachiewicz:agent/sweep-test-dead-fields
Draft

slachiewicz wants to merge 1 commit into
apache:masterfrom
slachiewicz:agent/sweep-test-dead-fields

Conversation

@slachiewicz

@slachiewicz slachiewicz commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Remove the dead sink and sinkFactory fixture fields from MavenReportTest. They captured nothing the assertions read, so the single-page report fixture can simply record the method called and the locale.

  • Drop the sink / sinkFactory fields, the unused SinkFactory import, and the matching this.sink = sink assignment

Tracking: apache/maven#14072

Verified: JAVA_HOME=<Java 21> mvn -B -o verify → BUILD SUCCESS; MavenReportTest surefire count 1 before → 1 after (0 failures/errors)

@slachiewicz
slachiewicz marked this pull request as draft November 19, 2026 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant