Repository navigation
Replace utility calls with the JDK and modernize tests - #444
Merged
slachiewicz merged 3 commits intoNov 16, 2026
Merged
Conversation
slachiewicz
marked this pull request as ready for review
November 16, 2026 22:51
gnodet-bot
approved these changes
Nov 16, 2026
gnodet-bot
left a comment
Contributor
There was a problem hiding this comment.
This PR is a clean modernization — replacing StringUtils.isEmpty() calls with JDK-native equivalents and updating tests accordingly. Good direction.
One minor observation:
Line 275: The
origin == nullguard is dead code —Path.relativize(Path).toString()never returnsnullper the Java API contract (the method returns an empty path, not null, when both paths are equal). The condition could be simplified to justorigin.isEmpty().
This is harmless as defensive programming, so it does not block approval.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
…sourcesFiltering.java Co-authored-by: Guillaume Nodet - AI Bot <gnodet+bot@gmail.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mechanical cleanups in separate commits (libraries to JDK, tests), generated with OpenRewrite.
Verified:
mvn verify→ the same 94 test cases as on master.