Skip to content

Replace utility calls with the JDK and modernize tests - #444

Merged
slachiewicz merged 3 commits into
apache:masterfrom
slachiewicz:agent/jdk-and-test-cleanup
Nov 16, 2026
Merged

slachiewicz merged 3 commits into
apache:masterfrom
slachiewicz:agent/jdk-and-test-cleanup

Conversation

@slachiewicz

Copy link
Copy Markdown
Member

Mechanical cleanups in separate commits (libraries to JDK, tests), generated with OpenRewrite.

Verified: mvn verify → the same 94 test cases as on master.

@slachiewicz
slachiewicz marked this pull request as ready for review November 16, 2026 22:51

@gnodet-bot gnodet-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a clean modernization — replacing StringUtils.isEmpty() calls with JDK-native equivalents and updating tests accordingly. Good direction.

One minor observation:

Line 275: The origin == null guard is dead code — Path.relativize(Path).toString() never returns null per the Java API contract (the method returns an empty path, not null, when both paths are equal). The condition could be simplified to just origin.isEmpty().

This is harmless as defensive programming, so it does not block approval.


This review was generated by an AI agent, Hermès on behalf of @gnodet.

…sourcesFiltering.java

Co-authored-by: Guillaume Nodet - AI Bot <gnodet+bot@gmail.com>
@slachiewicz
slachiewicz merged commit 363b1be into apache:master Nov 16, 2026
2 checks passed
@github-actions github-actions Bot added this to the 3.5.2 milestone Nov 16, 2026
@slachiewicz
slachiewicz deleted the agent/jdk-and-test-cleanup branch November 17, 2026 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants