Conversation
jt2594838
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reduce duplicate timestamp flush overhead
The duplicate timestamp merge behavior is unchanged: each value column keeps the last non-null value at a timestamp.
Tests
Added correctness coverage for duplicate timestamps with the full measurement set.
Added correctness coverage after deleting a measurement, exercising column remapping.
Added an opt-in manual performance UT. It stays skipped during normal test runs and can be enabled with:
mvn test -pl iotdb-core/datanode -Dtest=AlignedFlushDuplicateTimeCheckPerformanceTest -Diotdb.aligned.flush.duplicate-check.perf.enabled=true
Benchmark workload: 16,384 rows, 8 aligned columns, four rows per duplicated timestamp, 128 scans per round, five rounds.
The optimized loop used about 33.33% of the legacy CPU time in this targeted benchmark.
Verification:
13 tests ran: 12 passed and the opt-in performance UT was skipped as expected.
This PR has:
Key changed/added classes in this PR