Validate region operation requests before submitting procedures - #18696
Open
CRZbulabula wants to merge 3 commits into
Open
CRZbulabula wants to merge 3 commits into
CRZbulabula wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
One or more issues must be addressed before approval.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Improves region-operation submission reporting by preserving ConfigNode status summaries through DataNode, JDBC, and CLI layers.
Changes:
- Adds per-region success/failure summaries and localized messages.
- Handles invalid, empty, duplicate, and null DataNode inputs.
- Exposes successful submission messages through JDBC warnings and CLI output.
| File | Description |
|---|---|
| iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/execution/config/executor/ClusterConfigTaskExecutor.java | Updated as part of this pull request. |
| iotdb-core/confignode/src/test/java/org/apache/iotdb/confignode/manager/ProcedureManagerReconstructRegionTest.java | Updated as part of this pull request. |
| iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java | Updated as part of this pull request. |
| iotdb-core/confignode/src/main/i18n/zh/org/apache/iotdb/confignode/i18n/ManagerMessages.java | Updated as part of this pull request. |
| iotdb-core/confignode/src/main/i18n/en/org/apache/iotdb/confignode/i18n/ManagerMessages.java | Updated as part of this pull request. |
| iotdb-client/jdbc/src/test/java/org/apache/iotdb/jdbc/IoTDBStatementTest.java | Updated as part of this pull request. |
| iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBStatement.java | Updated as part of this pull request. |
| iotdb-client/cli/src/main/java/org/apache/iotdb/cli/AbstractCli.java | Updated as part of this pull request. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
CRZbulabula
force-pushed
the
yongzao/region-operation-cli-result
branch
from
September 23, 2026 09:32
2705968 to
99f9c34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What problem does this solve?
MIGRATE REGION,RECONSTRUCT REGION,EXTEND REGION, andREMOVE REGIONcould skip invalid IDs or submit procedures for earlier regions before encountering a later validation failure. For example, requesting regions12,99could start work on region 12 even though region 99 does not exist.What changed?
REMOVE REGIONtarget instead of cleaning up its partition-table entries.This is validation-before-submission, not a transaction over asynchronous procedure execution or a rollback guarantee for failures during procedure submission.
Tests
executeandexecuteUpdate), and CLI tests verify error-code/message propagation and the CLI error return status.test-compileand the four focused unit-test classes pass; no integration-test cluster was started.git diff --checkpass.Validation commands: