fix(config-ui): make dev api proxy target configurable via env - #9166
Merged
Merged
Conversation
…KE_URL Allow overriding the Vite dev server /api proxy target using VITE_DEVLAKE_URL, defaulting to http://localhost:8080. This avoids modifying the tracked vite.config.ts during local or dev container development.
Contributor
Author
|
@klesh fixes the issue! |
klesh
approved these changes
Sep 24, 2026
klesh
left a comment
klesh
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Thanks for your contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
In
config-ui/vite.config.ts, the/apidev proxy target was hardcoded tohttp://localhost:8080/.When running the backend on a custom port, inside Docker/Dev Containers, or across remote hosts, developers were required to edit the tracked
vite.config.tsfile. This caused unnecessary git status noise and introduced the risk of accidentally committing local development endpoints.In contrast, the
/grafanaproxy directly below it already supported dynamic configuration throughVITE_GRAFANA_*environment variables, introduced in #8645.Solution
Added environment variable support for the
/apiproxy target, following the existing Grafana configuration pattern:VITE_DEVLAKE_URL— direct URL overrideVITE_DEVLAKE_PROTOCOL— defaults tohttpVITE_DEVLAKE_HOST— defaults tolocalhostVITE_DEVLAKE_PORT— defaults to8080Also documented the new
VITE_DEVLAKE_*variables inconfig-ui/env.example.Does this close any open issues?
Closes
<insert issue number>Screenshots
N/A — Build and development server configuration change.
Other Information
Verified with:
yarn tsc --noEmityarn buildCloses (#9154 )