Skip to content

ci: download TCK snapshots from the serialization_test_data layout #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leerho wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: download TCK snapshots from the serialization_test_data layout #775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/serde-compat.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@ jobs:
java-version: '25'
distribution: 'temurin'

# The Java profile generates its own snapshots before checking them.
- name: Download ${{ matrix.name }} snapshots
if: matrix.language != 'java'
run: ./tools/download_serialization_test_data.sh ${{ matrix.language }}

- name: Run Java tests against ${{ matrix.name }} snapshots
Expand Down
6 changes: 3 additions & 3 deletions tools/download_serialization_test_data.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
set -euo pipefail

# Pin the archive so compatibility tests always use an immutable snapshot set.
readonly TCK_REVISION="d363b12d293b395d90abb42677f9ea63178dbc0d"
readonly TCK_REVISION="e748b0a038a17c6d5c771afc4efd9ee35a5a7ec5"
readonly TCK_ARCHIVE_URL="https://api.github.com/repos/apache/datasketches-tck/tarball/${TCK_REVISION}"
readonly SCRIPT_DIRECTORY="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
readonly REPOSITORY_ROOT="$(cd "${SCRIPT_DIRECTORY}/.." && pwd)"
Expand Down Expand Up @@ -103,7 +103,7 @@ for language in "${languages[@]}"; do

while IFS= read -r member; do
case "${member}" in
*/serialization/"${language}"/snapshots/*.sk)
*/serialization_test_data/"${language}"_generated_files/*.sk)
name="${member##*/}"
for existing_name in "${names[@]-}"; do
if [[ "${name}" == "${existing_name}" ]]; then
Expand All @@ -126,7 +126,7 @@ for language in "${languages[@]}"; do
tar \
-xzf "${archive_path}" \
-C "${staging_directory}" \
--strip-components=4 \
--strip-components=3 \
"${members[@]}"
for name in "${names[@]}"; do
if [[ ! -f "${staging_directory}/${name}" ]]; then
Expand Down
Loading