Skip to content

GEOMETRY-163: Preserve orthonormal basis under affine transforms - #304

Open
AryanRG wants to merge 1 commit into
apache:masterfrom
AryanRG:GEOMETRY-163-orthogonal-transform
Open

AryanRG wants to merge 1 commit into
apache:masterfrom
AryanRG:GEOMETRY-163-orthogonal-transform

Conversation

@AryanRG

@AryanRG AryanRG commented Oct 24, 2026

Copy link
Copy Markdown

Addresses GEOMETRY-163.

Shear and nonuniform scaling can leave EmbeddingPlane.transform() with non-orthogonal basis vectors, breaking toSpace/toSubspace round trips. Rebuild the transformed v direction from the normal and u direction while preserving the existing orientation and collapsed-plane checks.

Adds shear and scaling regressions and strengthens the transform consistency tests. mvn clean verify passes on Java 17.

Prepared with AI assistance.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.73%. Comparing base (cdf4381) to head (56fa02b).
⚠️ Report is 186 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #304   +/-   ##
=========================================
  Coverage     98.73%   98.73%           
  Complexity     3717     3717           
=========================================
  Files           193      193           
  Lines         10691    10702   +11     
  Branches       1565     1565           
=========================================
+ Hits          10556    10567   +11     
  Misses           15       15           
  Partials        120      120           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants