Repository navigation
Conversation
Generated-by: OpenAI Codex (GPT-6.1 Sol)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #304 +/- ##
=========================================
Coverage 98.73% 98.73%
Complexity 3717 3717
=========================================
Files 193 193
Lines 10691 10702 +11
Branches 1565 1565
=========================================
+ Hits 10556 10567 +11
Misses 15 15
Partials 120 120 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses GEOMETRY-163.
Shear and nonuniform scaling can leave
EmbeddingPlane.transform()with non-orthogonal basis vectors, breakingtoSpace/toSubspaceround trips. Rebuild the transformed v direction from the normal and u direction while preserving the existing orientation and collapsed-plane checks.Adds shear and scaling regressions and strengthens the transform consistency tests.
mvn clean verifypasses on Java 17.Prepared with AI assistance.