Repository navigation
Conversation
Keep the number of parsed header columns separate from the name-to-index map. Duplicate and empty names can collapse in that map, but records with all header positions must still be considered consistent. Cover both cases and add the Jira-linked changes entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CSVRecord.isConsistent()used the header-name map size as the header width. Duplicate or empty header names can collapse in that map, making a record with all columns appear inconsistent. Keep the parsed header column count separately and use it for consistency checks.Adds regression coverage for duplicate and empty names, plus a CSV-330 changes entry.
Jira: https://issues.apache.org/jira/browse/CSV-330
Validation
mvn— success on the final patch (JDK 27 on macOS).CSVRecordTest— 35 passing cases.AI assistance used (Kiro) for code and test drafting and independent patch review.