Repository navigation
Fix flaky tests main - #2060
Open
Alena0704 wants to merge 8 commits into
Open
Fix flaky tests main#2060Alena0704 wants to merge 8 commits into
Alena0704 wants to merge 8 commits into
Conversation
Alena0704
force-pushed
the
fix-flaky-tests-main
branch
2 times, most recently
from
September 29, 2026 16:40
c74f29d to
505f0f3
Compare
Alena0704
force-pushed
the
fix-flaky-tests-main
branch
from
September 29, 2026 16:59
505f0f3 to
15cf623
Compare
Alena0704
force-pushed
the
fix-flaky-tests-main
branch
3 times, most recently
from
October 4, 2026 21:09
42391a6 to
9e144de
Compare
Replace pg_sleep() with gp_stat_force_next_flush() to force a stats flush instead of waiting. Update the expected output. Assisted-by: Claude Code Backpatch-through: REL_2_STABLE
Assisted-by: Claude Code Backpatch-through: REL_2_STABLE
The test already averages CPU samples, but the expected values are still too low. The suite sets the cluster CPU limit to 100%, so expect 100% for one uncapped group and 33%/67% for groups with weights 100/200. Keep the existing tolerance of 10 percentage points. Assisted-by: Claude Code Backpatch-through: REL_2_STABLE
These tasks only check that valid schedules are accepted. Deactivate them after creation to avoid background runs interfering with cleanup and the oid_wraparound test. Assisted-by: Claude Code Backpatch-through: REL_2_STABLE
The tests read pg_stat_all_tables right after the DELETE, while the stats of the aborted inserts may not have arrived yet and those of the DELETE may already have. Wait for the stats of the aborts and read the view before the DELETE instead.
Run CHECKPOINT before waiting for the standby to catch up, so the slot's restart_lsn is updated before checking WAL status. Ported from Greenplum. Assisted-by: Claude Code Backpatch-through: REL_2_STABLE
Alena0704
force-pushed
the
fix-flaky-tests-main
branch
from
October 6, 2026 13:50
b9df400 to
4cfeffd
Compare
hot_standby/transaction_isolation deliberately panics the standby and reconnects to check distributed transaction visibility after recovery. The new connection can arrive before consistent recovery is reached, when the server reports "the database system is not yet accepting connections". This message was missing from the connection retry list. Retry this transient state using the existing attempt limit and interval. Keep the crash scenario and all transaction visibility checks intact. Backport required: REL_2_STABLE is affected by the same race.
Alena0704
force-pushed
the
fix-flaky-tests-main
branch
from
October 6, 2026 13:53
4cfeffd to
e9ab4a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collect all fixes from #2032 that can improve CI stability after having reviewed with refactored commit messages.
Author: Dianjin Wang wangdianjin@gmail.com
Assisted-by: Claude Code
Also ported fix for main from #2034
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions