Skip to content

CP to 2.77: Addfiles wiring provider (#40150) - #40199

Merged
claudevdm merged 1 commit into
apache:release-2.77from
claudevdm:cp-40150
Sep 22, 2026
Merged

claudevdm merged 1 commit into
apache:release-2.77from
claudevdm:cp-40150

Conversation

@claudevdm

Copy link
Copy Markdown
Collaborator
  • AddFiles: wire the schema pre-pass behind a Wait.on gate (batch)

AddFiles gets a ninth constructor argument, SchemaEvolutionConfig

With options set, the topology becomes

paths -> ReadFooterSchema -> CollectDistinctSchemas -> CommitSchemaOnce
|
paths -> Wait.on(signal) -> ConvertToDataFile -> ... (unchanged)

so no path reaches ConvertToDataFile until the schema commit has landed.

  • IcebergAddFiles provider: schema_evolution_options, required_columns, incompatible_schema_handling, unverifiable_file_handling

Exposes the pre-pass through the iceberg_add_files SchemaTransform and Beam YAML:

  • type: WriteToIceberg (transform: IcebergAddFiles in YAML)
    config:
    table: db.sales
    schema_evolution_options: [ALLOW_FIELD_ADDITION, ALLOW_TYPE_PROMOTION]
    required_columns: [id]
    incompatible_schema_handling: ROUTE_TO_ERRORS
  • trigger tests

  • simplify arg

  • tests

  • fixes

  • changes

  • comments, refresh only once per bundle

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

* AddFiles: wire the schema pre-pass behind a Wait.on gate (batch)

AddFiles gets a ninth constructor argument, SchemaEvolutionConfig

With options set, the topology becomes

  paths -> ReadFooterSchema -> CollectDistinctSchemas -> CommitSchemaOnce
                                                              |
  paths -> Wait.on(signal) -> ConvertToDataFile -> ... (unchanged)

so no path reaches ConvertToDataFile until the schema commit has
landed.

* IcebergAddFiles provider: schema_evolution_options, required_columns, incompatible_schema_handling, unverifiable_file_handling

Exposes the pre-pass through the iceberg_add_files SchemaTransform and
Beam YAML:

  - type: WriteToIceberg   (transform: IcebergAddFiles in YAML)
    config:
      table: db.sales
      schema_evolution_options: [ALLOW_FIELD_ADDITION, ALLOW_TYPE_PROMOTION]
      required_columns: [id]
      incompatible_schema_handling: ROUTE_TO_ERRORS

* trigger tests

* simplify arg

* tests

* fixes

* changes

* comments, refresh only once per bundle
@claudevdm
claudevdm requested a review from Amar3tto September 21, 2026 12:43
@claudevdm claudevdm added this to the 2.77.0 Release milestone Sep 21, 2026
@claudevdm

Copy link
Copy Markdown
Collaborator Author

@Amar3tto can you PTAL?

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @tvalentyn for label python.
R: @ahmedabu98 for label java.
R: @derrickaw for label yaml.
R: @ahmedabu98 for label iceberg.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@claudevdm
claudevdm merged commit e89883a into apache:release-2.77 Sep 22, 2026
110 of 111 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants