Repository navigation
exclude synthetic and ignored fields from json field filtering - #1308
Merged
robertlazarski merged 1 commit intoOct 11, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the ?fields= selector parsed by FieldFilteringMessageFormatter comes straight off the request query string, but getAllFields in JSONStreamingMessageFormatter and MoshiStreamingMessageFormatter only dropped static and transient fields before reflecting with setAccessible. naming a field the backend never serializes widens the response instead of narrowing it: this$0 on a non-static inner result class serializes the whole enclosing instance, and a moshi @JSON(ignore = true) field becomes readable by name even though the unfiltered response omits it. skip synthetic fields in both getAllFields implementations and honor @JSON(ignore) in the moshi one, so the filter can only select from what the unfiltered output already contains. added regression tests in the shared filter test base (runs against both delegates) and the moshi formatter test; all three fail before the change, and the full axis2-json suite passes after.