Conversation
| 3. Review the generated subject and body. Identify Apache Asyncband (Incubating), `${VERSION}`, and the RC; include the ATR candidate/revision, RC tag and commit, source checksum, KEYS and signer information, changelog, and verification evidence. Link ATR as the location of the voted files. Write the body as plain text for the mailing lists: no Markdown or backticks, prose wrapped near 72 characters, each label and its URL on separate lines, and no line break inside a word or checksum. Submit **Send vote email** when sending the vote is authorized, then record its archive link and closing time. | ||
| 4. Cast your own first-round vote with the checks you performed, either on the ATR vote page or by replying in the thread. A release manager has no implicit `+1`, so only an explicit vote counts towards the round. See the [ASF voting process](https://www.apache.org/foundation/voting.html). |
There was a problem hiding this comment.
I think we may try to see if ATR supports defining the email template as code instead of defining it on the platform. Then we can keep the email template in our repository. Then we don't need Point 3 at all, but that can be a follow-up to investigate.
There was a problem hiding this comment.
Agreed. And I took a look at the ATR code. Its "Export .asf.yaml" already writes start_vote_template, start_vote_subject, announce_release_template and a few other template fields under project.policy, so it seems we could keep the templates in our .asf.yaml, since we already have atr_sync on. I haven't checked yet whether the asfyaml side accepts those keys. I'll look into how to optimize this part later.
There was a problem hiding this comment.
This can be a follow-up PR that we review separately BTW.
|
Thanks for the review, I'll update this draft PR later. |
Summary
Refine the release skill with what the 0.7.3 release run showed, tracked in #327.
KEYS, since ATR imports the committee's keys from the distribution area rather than accepting an upload.releaseenvironment approvals, for composition and for the final tag, as actions for a reviewer listed in.asf.yaml, which the release manager performs only when listed there.+1under the ASF voting process.KEYS, so the existing pointer did not lead to the cause. See Automated source release upload to ATR fails: project signing key UID does not match ATR naming #329.Validation:
cargo x lint.