Skip to content

GH-51485: [Dev][Tutorial] Fix SC2086 errors in cpp/examples/tutorial_examples directory - #51486

Open
hiroyuki-sato wants to merge 5 commits into
apache:mainfrom
hiroyuki-sato:topic/shellcheck-tutorial_examples
Open

hiroyuki-sato wants to merge 5 commits into
apache:mainfrom
hiroyuki-sato:topic/shellcheck-tutorial_examples

Conversation

@hiroyuki-sato

@hiroyuki-sato hiroyuki-sato commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

Rationale for this change

This is the sub issue #44748.

In build_arrow.sh line 23:
mkdir -p $ARROW_BUILD_DIR
         ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
mkdir -p "$ARROW_BUILD_DIR"


In build_arrow.sh line 24:
pushd $ARROW_BUILD_DIR
      ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
pushd "$ARROW_BUILD_DIR"


In build_arrow.sh line 33:
    $ARROW_CMAKE_OPTIONS
    ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    "$ARROW_CMAKE_OPTIONS"


In build_arrow.sh line 35:
make -j$NPROC
       ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
make -j"$NPROC"


In build_example.sh line 21:
mkdir -p $EXAMPLE_BUILD_DIR
         ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
mkdir -p "$EXAMPLE_BUILD_DIR"


In build_example.sh line 22:
pushd $EXAMPLE_BUILD_DIR
      ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
pushd "$EXAMPLE_BUILD_DIR"


In build_example.sh line 24:
cmake /io $EXAMPLE_CMAKE_OPTIONS
          ^--------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
cmake /io "$EXAMPLE_CMAKE_OPTIONS"

For more information:
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

What changes are included in this PR?

  • SC2086: Quote variables

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

Was AI used for this PR?

PR code and description written by:

  • Human
  • AI

Reviewed before submission by:

  • Human
  • AI
  • Not reviewed

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #51485 has been automatically assigned in GitHub to PR creator.

@hiroyuki-sato
hiroyuki-sato marked this pull request as ready for review September 24, 2026 13:27
@hiroyuki-sato

Copy link
Copy Markdown
Collaborator Author

@github-actions crossbow submit example-cpp-tutorial

@github-actions

Copy link
Copy Markdown

Revision: 26b4792

Submitted crossbow builds: ursacomputing/crossbow @ actions-8634febb61

Task Status
example-cpp-tutorial GitHub Actions

@hiroyuki-sato
hiroyuki-sato marked this pull request as draft September 25, 2026 00:32
@hiroyuki-sato

Copy link
Copy Markdown
Collaborator Author

@github-actions crossbow submit example-cpp-tutorial

@github-actions

Copy link
Copy Markdown

Revision: 4267a0c

Submitted crossbow builds: ursacomputing/crossbow @ actions-18b7449048

Task Status
example-cpp-tutorial GitHub Actions

@hiroyuki-sato

Copy link
Copy Markdown
Collaborator Author

@github-actions crossbow submit example-cpp-tutorial

@github-actions

Copy link
Copy Markdown

Revision: b01de08

Submitted crossbow builds: ursacomputing/crossbow @ actions-c1b2bdb0ff

Task Status
example-cpp-tutorial GitHub Actions

@hiroyuki-sato
hiroyuki-sato marked this pull request as ready for review September 25, 2026 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant