Repository navigation
Mark builder as notThreadSafe for spotbugs - #6593
Merged
ddanielr merged 1 commit intoOct 16, 2026
Merged
Conversation
A newer spotbugs version throws errors that this class is not thread safe. Since this is a builder class, we don't expect multiple threads to ever use it so marking it as "NotThreadSafe" is sufficent.
dlmarion
approved these changes
Oct 16, 2026
dlmarion
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A newer spotbugs version throws errors that this class is not thread safe.
Since this is a builder class, we don't expect multiple threads to ever use it so marking it as "NotThreadSafe" is sufficient to stop spotbugs from erroring.
This change is related to #6486. Since that PR is rather large I'm breaking down the changes into smaller change sets with the final PR being the spotbugs version bump.