Skip to content

Revert AtomicInteger changes - #6592

Open
Amemeda wants to merge 2 commits into
apache:mainfrom
Amemeda:6542-revert-atomic-int
Open

Amemeda wants to merge 2 commits into
apache:mainfrom
Amemeda:6542-revert-atomic-int

Conversation

@Amemeda

@Amemeda Amemeda commented Oct 15, 2026 •

Copy link
Copy Markdown
Collaborator

Revert AtomicInteger changes from #3219. AtomicInteger cur is now volatile int cur in SeekableByteArrayInputStream.java, references and usages in class also reverted.

Keeps the NotThreadSafe tag on the class.

Closes #6542

@Amemeda
Amemeda marked this pull request as ready for review October 15, 2026 19:28

@dlmarion dlmarion left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks correct. However, I may have marked #6542 with the wrong milestone. I'm wondering if the correct target for this is the 2.1 branch, not main. Could you look at that aspect and change the target if appropriate?

@Amemeda

Amemeda commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator Author

The milestone should be correct, the original pr that changed cur to AtomicInteger was merged into main, and the 2.1 branch still has cur as an int.

@Amemeda
Amemeda requested a review from ctubbsii October 19, 2026 19:33

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SeekableByteArrayInputStream - revert #3219?

3 participants