Repository navigation
Avoid putting the MAC JVM in server mode when setting goal state - #6590
Merged
Merged
Conversation
ddanielr
approved these changes
Oct 15, 2026
dlmarion
approved these changes
Oct 15, 2026
dlmarion
left a comment
dlmarion
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. I always get confused about the SingletonManager.
Amemeda
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6582 had a side affect which caused
AccumuloClientIT.testCloseandCleanUpITto fail. This was because theSingletonManagerwas being switched to server mode because MACstart()was creating aServerContext. Server mode makes it so that client resources are no longer cleaned up when the last client closesThe fix for this was to change how we set the manager goal state. Building a
ZooReaderWriterdirectly instead of using the one off aServerContext. I updated the helper methodSetGoalState.setGoalStateto accept ZRW as a param instead so MAC andmain()still share it.The
var reservation = SingletonManager.getClientReservation()was added to protect a case I noticed while looking at the singleton code. Now that we are staying in client mode, the zookeeper sessions are shut down when no client is open, so if a MAC starts after the last client was closed, it would fail. I don't thing any of our ITs hit this case but other MAC usage could.