Repository navigation
Conversation
Amemeda
commented
Oct 7, 2026
Amemeda
marked this pull request as ready for review
October 8, 2026 15:40
Member
|
I think there are some issues with this approach. This new code replaces the status the server sends with one recomputed from the counts which loses things the server already checks for (like WARN for servers that are not reporting metrics will now show green here). It also only fixes the scan servers circle in the drop down and does not properly affect the rolled up Servers circle which still uses the old status so it will stay red with 0 scan servers. I think the only change we need is in |
Contributor
Author
dlmarion
reviewed
Oct 13, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This pr fixes a bug in the 4.0.0 Monitor where the Scan Server status icon in the Server drop-down does not display the correct status color. Added new logic to correctly determine the color of the Scan Server status icons:
Scan Server Status Icon should be:
This pr closes #6576
OK Status:
WARN Status:
**ERROR Status: **