Repository navigation
Conversation
…limits, activity audit - New accounts start every newsletter with "Ask me before an agent sends" on, which now also holds billing changes, for every key, MCP session and OAuth app; older accounts keep their behavior and the Approvals page offers it. - Team approvers per newsletter and an optional code by email to approve sends and deletes; the log names who decided and how. - Activity log: owner-chosen retention (30/90/180/365), filter by client, CSV export, auditRead keys, team members' changes recorded by name and role. - API keys can be limited to a list of actions and to IP addresses or CIDR ranges; OAuth apps can be limited to one newsletter on the consent page. - RateLimit-* headers on every API and MCP answer; team roles documented from the table the check reads. docs/capability-gaps/STATUS.md has the per-gap status, the plan report (G9), behavior changes and the rollout order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the capability gaps from section 5.9 of the agent-native newsletter study. The per-gap status, files and tests, the plan report (G9), the behavior changes and the rollout order are in
docs/capability-gaps/STATUS.md.What changes
change_plan,set_extra_emails_limit,add_dedicated_ip) for every API key, MCP session and OAuth app. Older accounts are unchanged, and the Approvals page offers to turn it on. Switching it is logged with who did it.set_team_approver). Approvers can't approve billing changes or change approval settings. An optional 6-digit code by email is required to approve sends and deletes (set_approval_step_up). Both are dashboard-only and off by default.list_agent_activitycan filter byclientandactorType.export_agent_activityexports CSV, also from a button on the Agent activity page. AnauditReadkey permission, never granted by default, lets a key read the whole log. Team members' dashboard changes are logged by name and role.create_api_keytakesactions(a list of allowed actions) andallowedIps(addresses or CIDR ranges, checked against Cloudflare's client-IP header; 403 without revealing the list, and the attempt is logged).RateLimit-Policy,-Limit,-Remainingand-Resetheaders on every API and MCP answer, plusRetry-Afteron a 429.TEAM_ROLE_CLASSES), read by the permission check, the docs andget_agent_brief.0051_agent_activity_client.sql, one index.Behavior change to know
A full access key on a new account's newsletter now gets
202 approval_requiredfor sends, deletes and billing changes. Before the test helper was changed, 186 tests in 52 files failed for exactly this reason. Test accounts are now set up as older accounts, andtests/capability-gaps.test.mjstests the new default on its own.Checks
Full suite: 363 files, 4,128 tests passed, 0 failed. Lint: 0 errors (2 warnings that were already there).
npm run buildpasses. The new UI on the Approvals page, the Agent activity page and the consent page was not clicked through in a browser.Before turning on step-up
The step-up code goes through
lib/platform-email.js, which uses Resend ifRESEND_API_KEYis set. Leave it unset to keep these emails on SES.