Repository navigation
Prepare SES account migration with scoped sending and signed feedback - #40
Merged
Merged
Conversation
ankurmans
marked this pull request as ready for review
November 12, 2026 00:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving SES accounts requires both sending access and feedback from the destination. This adds an explicit signed-topic allowlist for migration, tags newly provisioned SES resources for restricted IAM access, and lets platform mail explicitly select SES while retaining its previous key for rollback. Existing message templates, signing secrets and unsubscribe behavior stay intact.
The existing authentication rotation test exposed a concurrent key-retirement race; the fix retires and reports each unreadable key once. A dedicated regression test covers concurrent requests.
Validation: full suite 4,101 passed, four skipped; lint has no errors and two existing warnings; production OpenNext/API/readers builds and size checks passed. The API budget now records the already-shipped provider cost: baseline main builds 8,852,582 bytes, the migration 8,827,410 bytes. No migration SDK was added.
Production migration, sending credentials and end-to-end delivery tests are tracked separately from these local checks.