Skip to content

Fixes issue #1245 (and includes pull request #1278) - #1289

Open
ErwanH29 wants to merge 1 commit into
amusecode:mainfrom
ErwanH29:hill_spacing_oligarchic
Open

ErwanH29 wants to merge 1 commit into
amusecode:mainfrom
ErwanH29:hill_spacing_oligarchic

Conversation

@ErwanH29

@ErwanH29 ErwanH29 commented Nov 7, 2026

Copy link
Copy Markdown
Collaborator

Added an input parameter to make_planets_oligarch.new_system which now takes in a Hill separation. All planets are separated by this Hill parameter (i.e there is no scatter). This fixes issue #1245.

Other changes include:

  • Removing the particle superset as it wasn't so user friendly.
  • Including an example snippet in the docstrings. This was also used to test planets remain initially bound to the star.
  • Changing of several variable names to reduce clutter.

Lastly, this PR also fixes a bug in the development side of AMUSE which Lourens had already fixed in PR #1278. I just used his snippet. Likely not the `clean' way to go, but it fixes two issues at once so.

@spzwart

spzwart commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator

I would like to approve this change, but how?

@LourensVeen

Copy link
Copy Markdown
Member

They are not very well written, but there are instructions at https://docs.github.com/en/pull-requests/how-tos/review-pull-requests/reviewing-proposed-changes-in-a-pull-request. In short, you go to the Files changed tab at the top, and use the big green "Submit review" button at the top.

If you want to comment or request changes, then you can scroll down to the code you want to comment on and click the blue + to open a comment box. The green button there will also start a review, or add the comment to an existing review, and when you're done you can finalise the review using the green button at the top, where you can give a final verdict.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

3 participants