Repository navigation
docs(mongodb): scope Percona MongoDB guide to tested ACP versions; fix PRIVATE_REGISTRY overwrite - #855
Open
SuJinpei wants to merge 2 commits into
Open
docs(mongodb): scope Percona MongoDB guide to tested ACP versions; fix PRIVATE_REGISTRY overwrite#855SuJinpei wants to merge 2 commits into
SuJinpei wants to merge 2 commits into
Conversation
…ly tested The guide claimed ACP 4.x, but it has only been tested on ACP 4.2 (fully) and ACP 4.4 (baseline deployment only, #850). ACP 4.0, 4.1 and 4.3 were never tested. - ProductsVersion: 4.x -> '4.2,4.4' - Prerequisites: "ACP 4.x cluster" -> "ACP 4.2 or 4.4", untested 4.x noted - Verified versions line states the 4.4 scope and links to the table - Verified by Alauda table gets ACP 4.2 / ACP 4.4 columns so the 4.4 claim cannot be read as covering failover, backup, TLS, upgrade, resize or scaling Same changes in en and zh; zh sourceSHA bumped to the new en file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… exports it
Prerequisites exports PRIVATE_REGISTRY (host[:port]/project), but Step 1
(Option A, Option B, ACP Harbor) and Step 4 re-assigned it to a placeholder
or rebuilt it. A reader who pasted those blocks verbatim overwrote the
real value with a literal "<your-private-registry>", and Step 4's sed then
rewrote operator images to that string.
- Remove every PRIVATE_REGISTRY assignment outside Prerequisites; each
block that uses it starts with a ${PRIVATE_REGISTRY:?...} guard
- Derive REGISTRY_SERVER as "${PRIVATE_REGISTRY%%/*}" (host only) instead
of asking for it separately, so the two can no longer disagree
- Step 2: REG_USER / REG_PASS keep values already set by the Step 1 Harbor
section instead of overwriting them with placeholders; prose updated
- Step 1 registryAddress hint now points at PRIVATE_REGISTRY
Same changes in en and zh; zh sourceSHA bumped to the new en file.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SuJinpei
changed the title
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes to the Percona MongoDB Operator guide (KB260400014), applied in both en and zh.
1. Scope the guide to the ACP versions actually tested
The guide says it applies to ACP 4.x. It has only been tested on two ACP versions:
bundle.yamlinstall, sharded MongoDB8.0.19-7reachingready, Step 6 access checkProductsVersion: 4.xbecomes'4.2,4.4'. The quoted comma form is already used elsewhere in this repo.ACP 4.2/ACP 4.4columns. Failover, backup/restore, TLS, upgrade, PVC resize and scaling now say "Not tested" for 4.4. Before, a reader of the table could assume they were verified there.2. Stop overwriting
PRIVATE_REGISTRYafter Prerequisites exports itPrerequisites exports
PRIVATE_REGISTRY(host[:port]/project). The guide then re-assigned it in four places: Step 1 Option A, Option B, the ACP Harbor section, and Step 4. Two of them set it to the literal placeholder"<your-private-registry>". Pasting Step 4 as written made thesedrewrite operator images to<your-private-registry>/percona/....PRIVATE_REGISTRYany more. Each block that uses it starts with a${PRIVATE_REGISTRY:?...}guard.REGISTRY_SERVERderived: it is now computed as"${PRIVATE_REGISTRY%%/*}"(the host only) instead of being set separately, so the two values can't disagree.REG_USER/REG_PASSnow keep the values the Step 1 Harbor section already set. Before, the block overwrote them with placeholders while the prose said "you already have these set".The new shell lines were checked in bash. The host comes out as
acp.example.com:45443fromacp.example.com:45443/middleware, values that are already set are kept, and an unsetPRIVATE_REGISTRYproduces the error.zh
sourceSHAis bumped to the sha256 of the new en file.🤖 Generated with Claude Code