Repository navigation
fix(transcript): open generated images in the lightbox on click - #183
Merged
touch2be merged 1 commit intoOct 26, 2026
Merged
Conversation
Images from `generate_image` (and other tool image output) rendered as a plain <img> in ToolImages with no click handler, so they could not be enlarged; only markdown images and @image mentions opened the lightbox. Each tool image is now a button that opens the existing ImageMentionLightbox with the saved Host path, resolved through the same attachment base URL as the inline preview. Escape, the backdrop, or the close button dismiss it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Images created with image generation (
generate_image, #176) are shown inline in the transcript, but clicking them did nothing.ToolImagesrendered a plain<img>without a click handler; the lightbox was only wired up for markdown images () and@imagementions.Fix
ToolImagesis now a button (zoom cursor, hover/focus ring,attachments.openImagelabel) that opens the existingImageMentionLightbox.attachmentBaseUrlas the inline preview, so Desktop Local, Remote Hosts, and bearer-token Hosts behave like the thumbnail.readon an image file).Tests
ToolImages.test.tsx: click opens the lightbox with the same image source and saved path; Escape closes it.vp checkand the message-list / MarkdownRenderer tests pass.🤖 Generated with Claude Code