Repository navigation
Conversation
|
OX Security reviewed this pull request — nothing to fix.
Branch |
Codecov Report✅ All modified and coverable lines are covered by tests. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Why
Our org requires every action to be pinned to a full commit SHA. That rule also covers the actions that other actions use inside them (transitive dependencies). We do not control those inner pins: when an upstream action pins one of its own actions to a version tag, our pipeline fails, even when this repo pins everything by SHA. The lockfile records the SHA of every action, also the inner ones, and GitHub accepts it as SHA pinning.
We will soon turn on the org-wide GitHub policy "Require lockfile". After that, a workflow that is not in this lockfile cannot run. Please keep
actions.lockup to date when you change a workflow. Docs: https://docs.github.com/en/actions/concepts/security/workflow-dependency-lockfilesHow
.github/workflows/actions.lock, generated withgh actions-lock --no-interactive --migrate-local-actions --no-narrow(github/gh-actions-lock v0.4.1). Renovate updates the lockfile in its own PRs.uses: ./.github/actions/xtouses: $/.github/actions/x.$/is the GitHub syntax for an action in the same repo at the running commit. The lockfile needs it to lock the actions that a local action uses. The same change ran green on our runners in the dsb repo (PR 246).Docs: https://docs.github.com/actions/concepts/security/workflow-dependency-lockfiles
Verified
gh actions-lock --verify-localpasses: all 21 workflows have complete lockfile coverage.gh actions-lock --verifypasses locally../to$/lines.Not verified