Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToolCallTrackerretains references to nestedraw_inputandraw_outputvalues. Mutating arguments afterstart()/progress(), or editing a returned notification/view, silently changes the tracked state.tool_call_model()documents a deep copy but shares those raw values too: aPermissionBrokerrequester that normalizes its request can alter the tracker's data.Copy raw payloads on ingress and at each export boundary, matching the existing content/location ownership policy and
SessionAccumulator's raw-payload handling. Start/progress notifications, views, and permission models each have detached nested data. ExplicitNoneclearing and scalar/list JSON values retain their behavior. The public tracker docstring documents ownership.Validation
11f8a4c, with the new tests: 13 failed, 15 passed in tracker/permission tests. Every ingress/export path shares mutable raw data before this change, including the publicPermissionBrokerflow.make check: passed (lockfile, all pre-commit hooks, Ruff, ty, deptry).make test: 468 passed, 1 skipped (optional Gemini CLI test).git diff --check: passed.Tests use public tracker/broker APIs and a local requester callback. No model calls, external services, schema generation, API signatures, or dependency changes.
AI assistance disclosure: Codex prepared the patch, tests, and description and ran the checks above. No human code review is claimed.