Repository navigation
ci: run e2e against upstream A0, not the fork (DEC-082) - #28
Merged
Merged
Conversation
The devkit defaults a0_image to ghcr.io/nuevanext/agent-zero:latest-nonroot and this repo never overrode it, so every PR has been proving the plugin works on the private fork while upstream — the only thing anyone actually runs — was verified nowhere. Coverage was aimed at the wrong image. Overridden per repo rather than by changing the devkit default, so the change is scoped to this plugin. If this turns the suite red, that is the point: it means the plugin does not work for the only consumer it has, and the PR e2e is now the place that says so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the PR gate test what customers actually run.
The devkit defaults
a0_imagetoghcr.io/nuevanext/agent-zero:latest-nonroot— the private fork — and this repo never overrode it. So every PR here has been proving the plugin works on the fork, while upstream A0, the only thing anyone actually runs, was verified nowhere.That is not a coverage gap so much as coverage aimed at the wrong image.
Overridden per repo rather than by changing the devkit default, so the blast radius is this plugin only.
If this turns the suite red, that is the point. It means the plugin does not work for the only consumer it has, and the PR e2e is now the place that says so — before merge, with the diff in front of you, instead of in production.
Paired with testkit#59, which adds a digest-gated
upstream-compatschedule to catch upstream moving underneath us — something no PR can catch, because nothing in the repo changed.