Repository navigation
fix(ci): upstream-compat DEVKIT_PATH must be tests/_testkit, not . - #62
Merged
Merged
Conversation
Second failure: the checkout fix put the devkit at the workspace root, but DEVKIT_PATH=. makes the harness resolve the BDD config at WORKSPACE/./e2e/bdd which is the PLUGIN root — not the devkit. The plugin root has no e2e/bdd. The correct DEVKIT_PATH is tests/_testkit: the submodule inside the plugin checkout, same convention as plugin-e2e.yml. The harness invocation must also reference the plugin copy of the harness script for path consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second fix to
upstream-compat. The checkout fix (#61) got the devkit into the workspace, butDEVKIT_PATH=.made the harness look atWORKSPACE/./e2e/bdd— the plugin root, which has noe2e/bdd.The correct value is
tests/_testkit: the submodule inside the plugin checkout, same convention asplugin-e2e.yml. The harness invocation must also run the plugin's copy of the harness script for path consistency.Will re-dispatch after merge to prove all four legs green.