Repository navigation
Mahjong findings - #2014
Merged
Merged
Mahjong findings#2014
Conversation
wolfcomp
requested changes
Oct 19, 2026
wolfcomp
left a comment
Collaborator
There was a problem hiding this comment.
Unsure currently how to deal with the base type.
Vtable size is the same but vf1 is a nullptr in the base type.
Co-authored-by: wolfcomp <4028289+wolfcomp@users.noreply.github.com>
wolfcomp
requested changes
Oct 19, 2026
Co-authored-by: wolfcomp <4028289+wolfcomp@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the structs for reading a Doman Mahjong table during a match (hand, drawn tile, discards, melds, dora indicators, riichi state, points and round info), along with their data.yml entries.
C# representation for the functions and the rest of the Mahjong types can come in later PRs.
The commits and a fair bit of the reverse engineering was done assisted by an LLM.