Repository navigation
docs(warehouse-native): blur credentials in BigQuery connection screenshot - #295
Merged
Merged
Conversation
…nshot The connected-state screenshot on the BigQuery page showed a real service account's private key, client email and client ID, plus the project and dataset IDs. Pixelate and blur those fields so no credential data is readable; the form layout and "Connected" badge are unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
chris-absmartly
requested review from
bmsilva,
calthejuggler and
marcio-absmartly
as code owners
October 1, 2026 14:03
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID:
Comment |
calthejuggler
approved these changes
Oct 1, 2026
✅ Deploy Preview for absmartly-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Successful BigQuery connection test" screenshot on Connect BigQuery showed real connection details in plain text:
This PR pixelates and blurs those fields in
static/img/warehouse-native/datasource-bigquery-connected.pngso none of the data is readable. The rest of the screenshot (form layout, labels and the "Connected" badge) is unchanged, so it still illustrates the step.The page's other screenshot (the empty form) contains no sensitive data and is untouched.
Still needed after merging
Blurring the image does not make the key safe. It has been publicly visible on the docs site, and the original image stays in git history and any cached copies.
Test plan
🤖 Generated with Claude Code