Repository navigation
refactor: define terminal and interrupted task states in one place - #1396
Merged
Iwaniukooo11 merged 1 commit intoOct 27, 2026
Merged
Conversation
🧪 Code Coverage (vs
|
| Base | PR | Delta | |
|---|---|---|---|
| src/a2a/server/agent_execution/active_task.py | 95.81% | 95.79% | 🔴 -0.02% |
| src/a2a/server/cluster/database_event_stream.py | 96.94% | 92.86% | 🔴 -4.08% |
| src/a2a/server/cluster/database_task_store.py | 99.30% | 99.30% | ⚪️ -0.00% |
| src/a2a/server/request_handlers/default_request_handler.py | 97.99% | 97.99% | 🔴 -0.01% |
| Total | 93.41% | 93.37% | 🔴 -0.04% |
Generated by coverage-comment.yml
mykytanetipa
force-pushed
the
refactor/shared-task-state-sets
branch
from
October 27, 2026 14:55
93cc81c to
96e2501
Compare
mykytanetipa
force-pushed
the
refactor/shared-task-state-sets
branch
from
October 27, 2026 15:02
96e2501 to
4e75d94
Compare
mykytanetipa
marked this pull request as ready for review
October 27, 2026 15:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The set of terminal task states was copied in four places (ActiveTask, the legacy request handler, VersionedDatabaseTaskStore and TaskUpdater), and DefaultRequestHandlerV2 imported the state sets from the ActiveTask module. This moves TERMINAL_TASK_STATES and INTERRUPTED_TASK_STATES into a2a.utils.constants and re-uses them everywhere.
Notes