Skip to content

feat(cssholmes): add designer and gallery interfaces - #7

Merged
mambax7 merged 3 commits into
review/alpha1-1-runtimefrom
review/alpha1-2-presentation
Oct 27, 2026
Merged

mambax7 merged 3 commits into
review/alpha1-1-runtimefrom
review/alpha1-2-presentation

Conversation

@mambax7

@mambax7 mambax7 commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Summary

Part 2 of the cssHolmes 3.3.0 Alpha 1 release, split from #5 to keep automated reviews below 100 files. This PR changes 77 files.

Designer controls, gallery integration, templates and language strings.

Review and merge order

Runtime → presentation → documentation → quality. Base: review/alpha1-1-runtime. These are dependent review slices; the complete fourth branch is the release candidate. Do not deploy an intermediate slice.

The combined tree exactly matches release candidate 9b75e84ea2839b96dba219f80d531513ce34a9fa; splitting introduces no source changes.

Validation

The complete candidate passed local PHP 8.4/8.5 checks and browser regressions. A clean package was installed and upgraded from 3.0.0 on a disposable XOOPS 2.7.4-RC2 site, including normal login, editor save/reload, anonymous published CSS, CSRF checks and restore. Hosted CI passed on the complete candidate. The final upstream branch will also run CI before release.

No module-local vendor dependencies are added. PHP 8.4+ is required. Admin-theme publishing and native XOOPS 4 installation remain outside this alpha.

Copilot AI balanced review requested due to automatic review settings October 27, 2026 01:22
@sourcery-ai

sourcery-ai Bot commented Oct 27, 2026

Copy link
Copy Markdown

Sorry @mambax7, your pull request is larger than the review limit of 150,000 diff characters

@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f3568ece-89bd-48b9-982b-9f605a20a40a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@mambax7 mambax7 mentioned this pull request Oct 27, 2026
@mambax7
mambax7 merged commit 255072e into review/alpha1-1-runtime Oct 27, 2026
2 checks passed
@mambax7
mambax7 requested a lite review from Copilot October 27, 2026 02:19

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Unresolved export-permission enforcement, diagnostic-profile correctness, and French localization issues block approval.

5 open issues
1 file not reviewed
  • assets/css/gallery-designer.css: Generated file

Review effort: Lite

Comment thread assets/js/designer.js
Comment on lines +317 to +320
const exportCssButton = button('export_css', moreActions, () => download('css', compile(rules), 'text/css'));
const exportJsonButton = button('export_json', moreActions, () => {
if (libraryControls) libraryControls.exportSet.click();
else download('json', JSON.stringify({ theme: config.theme, rules }, null, 2), 'application/json');
Comment on lines +51 to +53
.holmes-debug body:not(:has(main)):not(:has([role="main"])) {
border-bottom: 5px solid #9b59b6 !important;
}
Comment on lines +116 to +121
.holmes-debug input:not([type="hidden"]):not([type="submit"]):not([type="button"]):not([type="reset"]):not([type="image"]):not([aria-label]):not([aria-labelledby]):not([id]),
.holmes-debug select:not([aria-label]):not([aria-labelledby]):not([id]),
.holmes-debug textarea:not([aria-label]):not([aria-labelledby]):not([id]) {
outline: 3px solid #9b59b6 !important;
--holmes-a11y: warning;
}
Comment on lines +93 to +105
[data-theme="dark"] .holmes-debug [style*="background: #fff"],
[data-theme="dark"] .holmes-debug [style*="background:#fff"],
[data-theme="dark"] .holmes-debug [style*="background: white"],
[data-theme="dark"] .holmes-debug [style*="background:white"],
[data-theme="dark"] .holmes-debug [style*="color: #000"],
[data-theme="dark"] .holmes-debug [style*="color:#000"],
[data-theme="dark"] .holmes-debug [style*="color: black"],
[data-theme="dark"] .holmes-debug [style*="color:black"],
[data-theme="dark"] .holmes-debug [style*="background: #ffffff"],
[data-theme="dark"] .holmes-debug [style*="background:#ffffff"] {
outline: 3px solid #9b59b6 !important;
--holmes-xtf-theme: warning;
}
Comment on lines +76 to +94
.holmes-debug .xtf-slot-widget > *:not([class*="xmf-"]) {
outline: 3px solid #f39c12 !important;
--holmes-xtf-widget: warning;
}

.holmes-debug .xtf-slot-widget > *:not([class*="xmf-"]):hover::after {
content: "Holmes: Widget root should have an xmf- prefixed class";
position: fixed;
top: 0;
left: 0;
padding: 8px 12px;
background: #f39c12;
color: #fff;
font-size: 13px;
font-family: system-ui, -apple-system, sans-serif;
z-index: 99998;
pointer-events: none;
white-space: nowrap;
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants