Repository navigation
docs(release): prepare 3.3.0 Alpha 1 after repository transfer - #14
Merged
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideDocumentation-only release preparation for cssHolmes 3.3.0 Alpha 1: repository links and QA references now use XoopsModules27x, obsolete review-branch guidance is removed, and the release notes identify xStyles 1.5.0 Beta 3 or later as the companion integration version; runtime code is unchanged. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 7 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 3 issues
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="README.md" line_range="35" />
<code_context>
browser regressions with an existing Playwright/Chromium installation.
-Source and issues: [XoopsModules25x/cssholmes](https://github.com/XoopsModules25x/cssholmes).
+Source and issues: [XoopsModules27x/cssholmes](https://github.com/XoopsModules27x/cssholmes).
The repository's CI checks PHP 8.4/8.5; release tags run CI before creating a
clean module ZIP. Qodana is optional and explicitly skips its scan when
</code_context>
<issue_to_address>
**Update checks miss official releases**
When a caller invokes `checkVerModule()` after the repository transfer, `checkVerModule()` still requests GitHub releases from `XoopsModules25x/cssholmes` instead of the official repository, so callers using the default source miss valid update information and download links.
Change `checkVerModule()` to request releases from `XoopsModules27x/cssholmes`.
Also at `docs/RELEASE-3.3.0-alpha.1.md:30`.
</issue_to_address>
### Comment 2
<location path="README.md" line_range="35" />
<code_context>
browser regressions with an existing Playwright/Chromium installation.
-Source and issues: [XoopsModules25x/cssholmes](https://github.com/XoopsModules25x/cssholmes).
+Source and issues: [XoopsModules27x/cssholmes](https://github.com/XoopsModules27x/cssholmes).
The repository's CI checks PHP 8.4/8.5; release tags run CI before creating a
clean module ZIP. Qodana is optional and explicitly skips its scan when
</code_context>
<issue_to_address>
**Pull requests go to the wrong repository**
When contributors follow the contribution instructions after the repository transfer, `CONTRIBUTING.md` still directs pull requests to `mambax7/cssholmes`, so contributors send them somewhere other than the official repository.
Update the contribution instructions to direct pull requests to `XoopsModules27x/cssholmes`.
Also at `docs/RELEASE-3.3.0-alpha.1.md:30`.
</issue_to_address>
### Comment 3
<location path="README.md" line_range="25" />
<code_context>
-Use a complete source checkout, including the testing/tooling files supplied by
-[the final QA change](https://github.com/XoopsModules25x/cssholmes/pull/9).
-Documentation-only review branches are incomplete; release ZIPs intentionally
+Use a complete source checkout from the repository. Release ZIPs intentionally
exclude `tests/`, PHPUnit configuration and other development files. If
`tests/run.php` is absent, obtain the complete source before running these commands.
</code_context>
<issue_to_address>
**Other guides still discourage test runs**
When a developer follows the verification instructions in either guide, `docs/visual-designer.md` and `docs/xoops4-migration.md` still say the test scripts arrive with a final QA change and are unavailable in documentation-only branches. A developer with the complete current source checkout can therefore be misled into thinking the tests are missing, contrary to the updated README instructions.
Remove the obsolete final-QA-change and documentation-only-branch caveats, and point readers to the complete-source-checkout instructions.
</issue_to_address>Sourcery assessment
Approval pending. 3 findings to address first.
Blocking findings: README.md:35, README.md:35, README.md:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare cssHolmes 3.3.0 Alpha 1 after the repository transfer to XoopsModules27x. Point release checks, source/help links and contribution instructions at the official repository. Remove obsolete review-branch instructions and identify xStyles 1.5.0 Beta 3 as the companion integration version.
Validation: PHP syntax and git diff --check pass. The standalone regression runner passes, including 35 PHPUnit tests / 115 assertions and 50 endpoint checks. Verified the official releases API responds. The archive is checked against the release commit and excludes development dependencies, tests and private workbench history.
The prepared release remains a draft. The only runtime change updates the release-check repository organization; other changes correct documentation and help links.