Skip to content

Add this to main please - #18

Closed
Ekwuno wants to merge 1 commit into
mainfrom
test-demo
Closed

Ekwuno wants to merge 1 commit into
mainfrom
test-demo

Conversation

@Ekwuno

@Ekwuno Ekwuno commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator

What this PR adds or changes

Checklist for new or changed examples

  • The example lives entirely in its own folder under examples/
  • node scripts/validate-examples.mjs --check passes (valid example.json, README present, index table in sync)
  • The README says what the artifact is, how to use it, and what to change before deploying it (the "Before you deploy" section)
  • No credentials, tenant names, or real personal data anywhere in the folder
  • node scripts/audit-examples.mjs --changed passes, or the findings it reports are explained below (see docs/EXAMPLE_BEST_PRACTICES.md)

Anything reviewers should know?

@github-actions

Copy link
Copy Markdown

Example audit

Audited examples/expense-policy-agent-skill. Passed: no hardcoded Workday URLs or app ids; no debug logging.

0 to fix and 1 suggestion(s).

Suggestions (1, never block)
Where Rule What to change
examples/expense-policy-agent-skill/README.md HubReadmeSectionsRule README.md has no "## Before you deploy" section. List everything a reader must change before this works in their tenant: app reference ids, base URLs, WIDs, security domains, dates or periods.

Run it yourself: ./scripts/install-arcane.sh once, then node scripts/audit-examples.mjs --changed. Rule explanations and fixes: docs/EXAMPLE_BEST_PRACTICES.md.

ACTION items fail the Audit examples check. ADVICE never blocks. Maintainers can add the audit-override label to merge with open ACTION items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants