Fix cancellation in named-query and recipe searches - #5430
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Named-query and recipe search discarded caller cancellation before reaching database queries. Propagate the token through a shared search database scope, interrupt running SQLite work, and check cancellation while materializing rows and aggregations. Issue-draft exports had the same database handoff gap and are covered too.
Cancellation remains an interruption across direct calls, CLI and serial/parallel batches, and the inherited reader restores its previous token after a cancelled nested query. Existing per-query failure handling must not turn cancellation into a degraded success or zero count.
Fixes #5427
Validation
make lint: passed, including cancellation test indentation.dotnet run --project tools/CodeIndex.Changelog -- check: 19 fragments validated.git diff --check: passed.Codex adversarial review of
origin/main..HEAD: No blocking/actionable issues found. The review independently reran the 7 cancellation tests, 12 related regression tests, and the fragment validator successfully.A second Codex review confirmed that the CI formatting correction changes only indentation, preserves behavior, and passes whitespace-format verification.
Documentation
USER_GUIDE.mdandTESTING_GUIDE.md.changelog.d/unreleased/5427.fixed.md;CHANGELOG.mdis unchanged.AGENT_GUIDE.mdare unchanged.No additional issues or follow-up findings are included.