Repository navigation
chore: add Renovate release-age gate and keep example algosdk in lockstep - #30
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two changes to the Renovate config so the issues fixed manually in #24 don't come back:
minimumReleaseAge: "2 days": Renovate waits until a release is 2 days old before proposing it. chore(deps): Update all non-major dependencies #24 pulled in algosdk 3.9.0 about 5 hours after it was published, and the non-major group automerges, so new releases could otherwise reachmainwith no waiting period.rangeStrategy: "bump"foralgosdk: because of:preserveSemverRanges, Renovate bumped the SDK's pinnedalgosdkdevDependency but left the examples at^3.5.2. Two copies got installed, their types clashed, andexamples/node-clifailed to build withTS2322. The rule bumps the examples' ranges along with the SDK's pinned version. It only matchesdependenciesanddevDependencies, so the SDK's^3.0.0peer range is never widened or narrowed for consumers.Testing
renovate-config-validatorpassesprettier --check renovate.jsonpasses