Repository navigation
fix(events): publish the refs a folded checkpoint skipped - #51
Conversation
yordis
commented
Oct 29, 2026
- A checkpoint that folded log entries before the events bridge read them made the bridge skip the gap, so webhook consumers never saw those pushes.
- The JetStream sink still skips such gaps; its cursor is the stream, so repairing it needs a ref baseline and is left for a separate change.
- Brings in events: publish the refs a folded checkpoint skipped tobi/walgit#109 by redhox, cherry-picked with original authorship; the upstream test fails on our main and passes with this change.
A checkpoint can fold log entries the events bridge has not read yet, so consumers lost the push. Store the refs visible at the published seq in the cursor and diff them against the current refs on a gap. (cherry picked from commit 4046b96 and ff6714f, tobi#109; adapted to the walgit-events crate) (cherry picked from commit 4046b96 and ff6714f (tobi#109), adapted to the walgit-events crate) Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
The unit tests cannot show that the cursor round trip and the sink path deliver what a folded checkpoint hid. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
PR SummaryMedium Risk Overview Legacy cursors without a Integration tests cover the full folded-gap scenario and legacy-cursor behavior. Reviewed by Cursor Bugbot for commit a948eab. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a5f9336. Configure here.
…creates A cursor without refs is not an empty snapshot, and the readable tail is published from the log, so the gap must end at the folding checkpoint. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
