Repository navigation
Choose where trips are stored: this PC, OneDrive or Google Drive - #6
Merged
Merged
Conversation
…Drive Settings now has a storage picker. Switching copies the trips to the new place (per trip the newer version wins), and the MCP server uses the same choice. - OneDrive: trips go into the TripDeck folder inside the OneDrive folder on this PC, which the OneDrive app syncs. No Microsoft sign-in or app registration is needed (personal accounts can no longer register apps outside a directory). The folder is found through %OneDrive% or ~/Library/CloudStorage, or set in Settings / TRIPDECK_ONEDRIVE_FOLDER. OneDrive's conflict copies are handled by reading the newest one. - Google Drive: trips move from the hidden appDataFolder to a visible My Drive > TripDeck folder with the drive.file scope. Existing connections keep working on the hidden folder until the user reconnects, which copies the trips over. - Cloud files are named "Name (id).tripdeck.json" in the Export JSON format, so they can be imported directly. - OAuth moves to lib/server/cloudAuth.ts and /api/auth/[provider]; the Google redirect URI is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3 tasks done
… tests CI now runs `bun run check` (typecheck, ESLint, tests with coverage, build) and the tests again on Windows. Coverage goes from ~32 % to ~88 % of statements, with thresholds that fail the run when it drops. New tests: - http: localhost-only guard, DNS rebinding, cross-site origin, JSON body validation, error mapping - cloudAuth: PKCE auth URL and scopes, code exchange, token refresh and revocation, offline errors - API routes: trips CRUD and id checks, storage switching, config never returning secrets, Google sign-in (state/CSRF check, hidden-folder migration) and disconnect - browser sync: newest wins, deletes, storage switch, offline; store actions; trip import - MCP server: the real server over stdio, planning a trip end to end - tripOps, maps fallback to OpenStreetMap, time and place helpers ESLint (eslint-config-next core-web-vitals + typescript) found and this fixes: a ref written during render in OsmMap, setState in effects in Settings and Splitter, and an unused MCP helper. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Raise the quality bar for pull requests: lint, coverage gate, broader tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Settings has a new Where your trips are stored section with three options: This PC, OneDrive and Google Drive. Switching copies the trips to the new place; when a trip exists in both, the newer version wins. The MCP server uses the same choice.
OneDrive (synced folder, no sign-in)
TripDeckfolder inside the OneDrive folder on this PC, and the OneDrive app syncs it to other devices, including the OneDrive phone app.%OneDrive%(Windows) or~/Library/CloudStorage/OneDrive-…(macOS). It can also be set in Settings or withTRIPDECK_ONEDRIVE_FOLDER.Google Drive (visible folder)
appDataFolderto My Drive › TripDeck, using thedrive.filescope. TripDeck still only sees files it created.Shared
Name (id).tripdeck.json, in the same format as Export → JSON, so the files can be imported directly.lib/server/cloudAuth.tsand/api/auth/[provider]/…. The Google redirect URI (/api/auth/google/callback) is unchanged, so existing OAuth clients keep working./api/storageswitches storage and copies the trips..env.exampleupdated.Test plan
bun run test: 40 tests pass. New tests cover the OneDrive folder store (renames, conflict copies, non-trip files, folder detection), the Google Drive visible folder and hidden-folder migration against a fake Drive API, storage fallback, andcopyTrips.bun run typecheckandnext buildTripDeck/with the badge showing "☁ OneDrive"🤖 Generated with Claude Code