Repository navigation
v0.4.0-dev fix: preserve selected-page assets and freeze real table holdouts - #9
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 857864123a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch debug assets used page-window ordinals instead of original PDF page indices. This fixes their identity and materialized source filtering, with regressions for noncontiguous source pages, coordinates, filenames, hashes and full-document behavior. Schema 0.19.2 identifies the output correction.
A new frozen real-document pack checks selected merged headers and continuation controls in three hash-verified government originals. Both public JSONL formats retain raw output and failures. Inputs stay in the ignored cache; CI tests the harness without fetching PDFs. Review also fixed descendant cleanup so timeout, normal exit and interruption finalize the owned process group and preserve receipts.
Validation: 62/62 Zig test steps, native/shared and WASM builds, 339 JavaScript tests, 93 Python tests, 16 existing public topology checks and 28 public reading-order checks pass. Retained source/binary hashes were rechecked before this PR. Independent review covered the 19-file implementation scope and reproduced the process-cleanup fix. Review remediation also rejects array-shaped public table bboxes in both JSONL formats while retaining list-shaped frozen truth coordinates.
Qualification: all six real-document case/format runs fail the complete table gate. The preserved baseline exposes region fragmentation, merged stacked regions, extra columns and missing merged-header structure. No thresholds or truth were relaxed; no parser tuning followed holdout assessment. Selected-cell truth and one positive-continuation template do not establish general table accuracy.
The monitored compiler-cache peak was 1.96 GiB against a 6 GiB observed budget. Cached tooling, prior verification evidence and database/container state were preserved.