Repository navigation
v0.4.0-dev fix: preserve table evidence and freeze ordering holdouts - #8
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 17b278303c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Table reconstruction could duplicate text crossing a shared rule, link whole-row evidence to an empty cell, and lose or misorder prose around a table. This keeps nonempty cell text and bounds through reconciliation, assigns shared-rule centers once, preserves surrounding prose, and resets legacy column order at corroborated section headings. The output bug fixes use schema 0.19.1.
New frozen topology and emitted-order suites score both public JSONL formats, enforce exact source ownership and physical grid dimensions, and retain failures. Native CI now runs their regressions and public extraction gates and uploads evidence even on failure. The project-local compiler monitor uses a 6 GiB observed allocation budget, a 12 GiB free-space floor, and two build jobs; it preserves evidence outside the cache and is not a filesystem quota.
Validation:
Automated review remediation: public extraction checks use the supported
--no-ocrflag. Synthesized cell identities survive reconciliation and scope source spans to their actual cell, including centers exactly on shared rules; blank cells claim neither spans nor blocks. Regressions cover both indexed and streaming selections, overlapping cell identities, and native duplicate merging. The ownerless-span geometric fallback remains documented.Qualification: the separate graph diagnostics still fail seven development and seven holdout checks and are not promoted. These small synthetic controls do not establish arbitrary real-document topology or reading-order accuracy.