Repository navigation
fix(ui): standardize controls on shadcn and repair modal selectors - #448
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardize Lite's frontend controls on the shadcn UI kit. Native selects now use Radix Select, while buttons, labels, single-choice controls, overview tabs and tables use shared shadcn components. A source-level check prevents business pages from reintroducing native controls.
Fix searchable menus inside dialogs, sheets and alerts by providing a modal-local popup container and closing the menu before the enclosing dialog on Escape. This resolves the search language/country menus that could be displayed but could not be clicked or scrolled, and replaces three page-specific workarounds.
Place web tools in the same auxiliary-request table. Use one shadcn multi-select engine menu: Automatic is exclusive, explicit engines can be selected together, and removing the final engine restores Automatic. Preserve saved engine order and distinguish explicit selection of all engines from Automatic. Present allowed and blocked domains as separate editable lists, including validation, deduplication and saving unfinished input. Keep the form body scrollable above its footer in compact windows.
Validation: 1,463 unit tests; 54 Chromium/WebKit browser checks using real mouse, wheel and keyboard input; typecheck; production build; actionlint; six native macOS WKWebView screenshot scenes. Browser checks cover all main pages, the connection picker, empty/disabled/grouped select values, multi-engine selection, keyboard search, Escape and focus return, save/reopen and failed-save behavior, and Chinese/English light/dark layouts at 1100×720 and 820×560. The browser suite now runs in CI alongside the existing checks.
Prepare Lite 2026.11.16 with matching package, Tauri, Cargo and lockfile versions, plus English release notes. Core remains pinned to v0.97.0.