Skip to content

Record timing flakes that fail outside the PR diff - #21

Merged
thedancingdeveloper merged 1 commit into
fork/mainfrom
fork/ci-known-flakes
Oct 10, 2026
Merged

Record timing flakes that fail outside the PR diff#21
thedancingdeveloper merged 1 commit into
fork/mainfrom
fork/ci-known-flakes

Conversation

@thedancingdeveloper

@thedancingdeveloper thedancingdeveloper commented Oct 10, 2026

Copy link
Copy Markdown

Summary

Adds four nextest filtersets to .github/fork-ci-known-failures.txt. Each fails on pull requests in files those PRs do not touch, and is green on the fork/main baseline, so fork-ci should treat them as known timing flakes.

  • pending_input_persistence::background_user_input
  • pending_input_persistence::synchronous_store
  • remote_env::future_pending_environment
  • hooks::permission_request_hook_allows_exec_command_without_user_approval (the marker-file assertion in codex-rs/core/tests/suite/hooks.rs at line 3042)

Evidence

Test plan

  • fork-ci parses the four lines into one not (...) filterset
  • the listed tests are omitted; other failures still fail the job

@thedancingdeveloper
Record timing flakes that fail outside the PR diff
0420db5 
These four tests fail on PRs #6 and #12 in files those PRs do not touch,
and they are green on the fork/main baseline. List them so fork-ci can
keep reporting real regressions.
@thedancingdeveloper
thedancingdeveloper merged commit b8011f5 into fork/main Oct 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@thedancingdeveloper