Repository navigation
fork-ci: green baseline on fork/main - #19
Merged
Merged
Conversation
nextest is fail-fast by default, so fork-ci cancelled a crate's remaining tests at its first failure. Each PR run therefore surfaced a single unrelated failure per crate, and fixing it only exposed the next one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fork/main sits on upstream tag rust-v0.162.0, whose release commit (c138238) bumps the workspace version from 0.0.0 to 0.162.0 and leaves Cargo.lock at 0.0.0. Upstream runs its tests at 0.0.0 and never on that commit, so on fork/main 37 codex-tui snapshots rendered v0.162.0 instead of v0.0.0, and packaged_daemon_bootstrap_seeds_local_package saw the seeded package as a stable release and enabled auto-update. Reset the workspace version to 0.0.0 for the job, the way upstream tests. fork-release stamps the real version separately. All 5710 codex-tui tests pass at 0.0.0 locally; 37 fail at 0.162.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3e2cb85 added the resolved workdir to exec_command's PreToolUse tool_input, but pre_tool_use_merges_hooks_json_and_config_toml compares the whole tool_input and still expected only command. The call sets no workdir, so it resolves to the session cwd. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
|
Oversight review: no blockers (head 92886e1)
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes fork-ci pass on code already in fork/main, so feature PRs (#6, #10, #12, #13, #14) stop failing on tests they don't touch. Tracked as Vogt WI-1157.
Why each PR showed a different single failure
nextest is fail-fast by default, so fork-ci cancelled a crate's remaining tests at its first failure (
3620/5075 tests run … 1 failed). Each PR surfaced one unrelated failure, and fixing it only exposed the next. The first commit adds--no-fail-fast, which also makes good on the step's own comment that "a PR should see all of its failures at once".Failures on unmodified fork/main (af8bd29) and how each is handled
app::daemon_menu::tests::daemon_menu_is_read_only_and_confirmation_can_cancel_or_handoff,status::tests::status_snapshot_*,history_cell::tests::*update_available*,update_prompt::tests::*rust-v0.162.0. Its release commit c138238 bumps the workspace version from 0.0.0 to 0.162.0, and Cargo.lock keeps 0.0.0. Upstream tests at 0.0.0 and never on the tag commit, so the snapshots renderv0.0.0. Every diff is only0.0.0→0.162.0.app_server_daemon::packaged_daemon_bootstrap_seeds_local_package(autoUpdateEnabledtrue, expected false)prepare_install::stable_versiontreats only 0.0.0 as a dev build. At 0.162.0 the seeded test package counts as a stable release and follows latest, so the updater is enabled.suite::hooks::pre_tool_use_merges_hooks_json_and_config_tomlworkdirto exec_command's PreToolUsetool_input. This test compares the wholetool_inputand expected onlycommand.workdirequal to the session cwd, because the call sets no workdir. Passes locally.suite::hooks::permission_request_hook_*FLAKY 2/2) in earlier fork-ci runs, under nextest'sretries = 1.all__suite__scenarios__astra_*snapshots.snap.newis left in any fork worktree..github/fork-ci-known-failures.txtstays empty: nothing needed excluding.Evidence
RUST_MIN_STACK, nextest 0.9.103,--no-fail-fast). Local-only failures came from the dev host, not the code: its AppArmor blocks bwrap namespaces, which CI enables, and the daemon app-server doesn't start there. CI is authoritative for those.--no-fail-fast, run 38016341231: exactly 38 failures, namely codex-tui 36 (5710 run), codex-cli 1 (packaged_daemon_bootstrap_seeds_local_package, 493 run) and codex-core 1 (pre_tool_use_merges_hooks_json_and_config_toml, 5075 run, 1 flaky that passed on retry). Every one is in the table above.Stray change: any cargo command rewrites Cargo.lock from 0.0.0 to 0.162.0 at this base. That rewrite is not committed, and with the reset it no longer happens in CI.
🤖 Generated with Claude Code