Repository navigation
fork-ci: raise the test thread stack to 8 MiB - #15
Merged
Merged
Conversation
cargo test -p codex-core aborts with "fatal runtime error: stack overflow" on the runner's default thread stack. Upstream sets RUST_MIN_STACK to 8 MiB on its test step in rust-ci.yml, and fork-ci now does the same.
thedancingdeveloper
left a comment
thedancingdeveloper
left a comment
Author
There was a problem hiding this comment.
Review: no blockers (head 1b40b84)
One commit on fork/main that adds RUST_MIN_STACK: "8388608" to fork-ci's cargo test step, matching upstream (rust-ci.yml:158). It fixes the codex-core stack overflow seen in #10's run 37947101661. Merge condition: its own fork-ci run is green. A workflow-only PR has no changed crates, so check/fmt/clippy/test are quick. After merge, re-run fork-ci on #10.
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan